Issue 1293703003: Attempt to fix MIPS inline assembly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1293703003: Attempt to fix MIPS inline assembly (Closed)

Created:
5 years, 4 months ago by Cutch

Modified:
5 years, 4 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Attempt to fix MIPS inline assembly BUG= Committed: https://github.com/dart-lang/sdk/commit/0ae35cdc56414f6f271cfeaf31ac4f5ea7deab97

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/globals.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #1 (id:1) manually as 0ae35cdc56414f6f271cfeaf31ac4f5ea7deab97 (presubmit successful).

5 years, 4 months ago (2015-08-14 14:00:43 UTC) #1

zra

5 years, 4 months ago (2015-08-14 14:30:02 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1293703003/diff/1/runtime/vm/globals.h
File runtime/vm/globals.h (right):

https://codereview.chromium.org/1293703003/diff/1/runtime/vm/globals.h#newcod...
runtime/vm/globals.h:116: #define COPY_FP_REGISTER(fp) asm volatile ("move %0,
$r30" : "=r" (fp) );
move %0, $fp builds

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages