Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 12935002: Change the IO buffer size on Windows to 32k (Closed)

Created:
7 years, 9 months ago by Søren Gjesse
Modified:
7 years, 9 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the IO buffer size on Windows to 32k This makes a program like this import "dart:io"; main() { stdin.pipe(stdout); } with stdin redirected from a file run 20 - 50 times faster depending in the file size piped through. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=20210

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/bin/eventhandler_win.cc View 3 chunks +4 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 9 months ago (2013-03-19 15:00:49 UTC) #1
Mads Ager (google)
LGTM https://codereview.chromium.org/12935002/diff/1/runtime/bin/eventhandler_win.cc File runtime/bin/eventhandler_win.cc (right): https://codereview.chromium.org/12935002/diff/1/runtime/bin/eventhandler_win.cc#newcode23 runtime/bin/eventhandler_win.cc:23: #define BUFFER_SIZE 32 * 1024 Please use a ...
7 years, 9 months ago (2013-03-19 15:11:20 UTC) #2
Søren Gjesse
https://codereview.chromium.org/12935002/diff/1/runtime/bin/eventhandler_win.cc File runtime/bin/eventhandler_win.cc (right): https://codereview.chromium.org/12935002/diff/1/runtime/bin/eventhandler_win.cc#newcode23 runtime/bin/eventhandler_win.cc:23: #define BUFFER_SIZE 32 * 1024 On 2013/03/19 15:11:20, Mads ...
7 years, 9 months ago (2013-03-19 15:26:48 UTC) #3
Søren Gjesse
7 years, 9 months ago (2013-03-19 15:27:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20210 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698