Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1293433003: Fix arguments passed to FileSystemException from _socketType, when failing to resolve the type. (Closed)

Created:
5 years, 4 months ago by Anders Johnsen
Modified:
5 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix arguments passed to FileSystemException from _socketType, when failing to resolve the type. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/54b7e9fec4773305a37b5c91310e4efae088ce49

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/stdio_patch.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Anders Johnsen
5 years, 4 months ago (2015-08-13 07:19:36 UTC) #2
Søren Gjesse
lgtm
5 years, 4 months ago (2015-08-13 07:25:24 UTC) #3
Anders Johnsen
5 years, 4 months ago (2015-08-13 07:32:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
54b7e9fec4773305a37b5c91310e4efae088ce49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698