Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1293383006: Dependency overrides override SDK constraints. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Dependency overrides override SDK constraints. Closes #1319 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/75dc04e89552d0be3eedf111185f08386056502f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
M lib/src/solver/backtracking_solver.dart View 1 chunk +13 lines, -12 lines 0 comments Download
M test/dependency_override_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-19 19:52:19 UTC) #1
Bob Nystrom
lgtm
5 years, 4 months ago (2015-08-19 20:31:00 UTC) #2
nweiz
5 years, 4 months ago (2015-08-19 20:51:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
75dc04e89552d0be3eedf111185f08386056502f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698