Enable allocation tracing for classes owned by vm isolate

Enable allocation tracing for classes owned by vm isolate

- Don't store the allocation tracing toggle bit in the class.
- Make sure that array and context slow path stubs are added to the code object's static call table.
- Add missing MaybeTraceAllocation to context allocation stub.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/ec675a3b0d2e3267631c58cfae3568af28aa693c

[Cutch, 2015-08-14 03:06:25]

johnmccutchan@google.com changed reviewers:
+ fschneider@google.com, iposva@google.com

[Ivan Posva, 2015-08-14 05:38:31]

Thanks,
-Ivan

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:1756: if (cls.TraceAllocation()) {
Please pass isolate as an argument here.

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:2759: Isolate* isolate = Isolate::Current();
Take from parameter.

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/object.h
File runtime/vm/object.h (left):

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/object.h#old...
runtime/vm/object.h:1370: return
TraceAllocationBit::decode(raw_ptr()->state_bits_);
Is the TraceAllocationBit still needed in the class state bits? If not, please
remove...

[Florian Schneider, 2015-08-14 11:35:10]

lgtm

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/stub_code_ia...
File runtime/vm/stub_code_ia32.cc (right):

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/stub_code_ia...
runtime/vm/stub_code_ia32.cc:814: /* near_jump = */ false,
Use Assembler::kFarJump instead.

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/stub_code_x6...
File runtime/vm/stub_code_x64.cc (right):

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/stub_code_x6...
runtime/vm/stub_code_x64.cc:854: /* near_jump = */ false,
Use Assembler::kFarJump instead.

[Cutch, 2015-08-14 13:54:36]

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:1756: if (cls.TraceAllocation()) {
On 2015/08/14 05:38:31, Ivan Posva wrote:
> Please pass isolate as an argument here.

Done.

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:2759: Isolate* isolate = Isolate::Current();
On 2015/08/14 05:38:31, Ivan Posva wrote:
> Take from parameter.

Done.

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/object.h
File runtime/vm/object.h (left):

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/object.h#old...
runtime/vm/object.h:1370: return
TraceAllocationBit::decode(raw_ptr()->state_bits_);
On 2015/08/14 05:38:31, Ivan Posva wrote:
> Is the TraceAllocationBit still needed in the class state bits? If not, please
> remove...

Done.

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/stub_code_ia...
File runtime/vm/stub_code_ia32.cc (right):

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/stub_code_ia...
runtime/vm/stub_code_ia32.cc:814: /* near_jump = */ false,
On 2015/08/14 11:35:09, Florian Schneider wrote:
> Use Assembler::kFarJump instead.

Done here and elsewhere.

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/stub_code_x6...
File runtime/vm/stub_code_x64.cc (right):

https://codereview.chromium.org/1292723002/diff/40001/runtime/vm/stub_code_x6...
runtime/vm/stub_code_x64.cc:854: /* near_jump = */ false,
On 2015/08/14 11:35:09, Florian Schneider wrote:
> Use Assembler::kFarJump instead.

Done here and elsewhere.

[Cutch, 2015-08-14 13:55:10]

Committed patchset #4 (id:60001) manually as
ec675a3b0d2e3267631c58cfae3568af28aa693c (presubmit successful).