Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1292063004: Add NoSafepointScope to ObjectPointerVisitor. (Closed)

Created:
5 years, 4 months ago by koda
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add NoSafepointScope to ObjectPointerVisitor. Also update some uses of NoHandleScope to NoSafepointScope, which basically means "do not risk GC here". BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b739b6319fe8e5a27e5e71785830b08cff934095

Patch Set 1 #

Patch Set 2 : Also in Scavenger. #

Total comments: 2

Patch Set 3 : Move implementation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -35 lines) Patch
M runtime/vm/allocation.h View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/allocation.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/heap.h View 1 chunk +0 lines, -20 lines 0 comments Download
M runtime/vm/heap.cc View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/raw_object.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/scavenger.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/visitor.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
koda
5 years, 4 months ago (2015-08-13 15:48:35 UTC) #2
Cutch
LGTM with one comment https://codereview.chromium.org/1292063004/diff/20001/runtime/vm/allocation.h File runtime/vm/allocation.h (right): https://codereview.chromium.org/1292063004/diff/20001/runtime/vm/allocation.h#newcode146 runtime/vm/allocation.h:146: private: The implementation of this ...
5 years, 4 months ago (2015-08-13 16:08:21 UTC) #3
koda
https://codereview.chromium.org/1292063004/diff/20001/runtime/vm/allocation.h File runtime/vm/allocation.h (right): https://codereview.chromium.org/1292063004/diff/20001/runtime/vm/allocation.h#newcode146 runtime/vm/allocation.h:146: private: On 2015/08/13 16:08:21, Cutch wrote: > The implementation ...
5 years, 4 months ago (2015-08-13 19:58:53 UTC) #4
koda
5 years, 4 months ago (2015-08-13 19:59:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b739b6319fe8e5a27e5e71785830b08cff934095 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698