Issue 12919020: Remove redundant Dart_LoadScript as it doesn't seem to be used in the VM and hopefully dartium uses…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12919020: Remove redundant Dart_LoadScript as it doesn't seem to be used in the VM and hopefully dartium uses… (Closed)

Created:
7 years, 9 months ago by siva

Modified:
7 years, 9 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Remove redundant Dart_LoadEmbeddedScript as it doesn't seem to be used in the VM and hopefully dartium can start using Dart_Script always. Committed: https://code.google.com/p/dart/source/detail?r=20277

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -74 lines)			Patch
M	runtime/bin/dartutils.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/include/dart_api.h	View	1 2	2 chunks	+1 line, -11 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2	2 chunks	+3 lines, -38 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2	15 chunks	+21 lines, -21 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/unit_test.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

siva

7 years, 9 months ago (2013-03-20 15:41:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r20277 (presubmit successful).