Issue 12918018: Update Intl's json data file generation to current APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12918018: Update Intl's json data file generation to current APIs (Closed)

Created:
7 years, 9 months ago by Alan Knight

Modified:
7 years, 9 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update Intl's json data file generation to current APIs Committed: https://code.google.com/p/dart/source/detail?r=20182

Patch Set 2 : Also remove polyfill reversing method #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -22 lines)			Patch
	M	pkg/intl/lib/date_format.dart	View	1	2 chunks	+1 line, -12 lines	1 comment	Download
	M	pkg/intl/tool/generate_locale_data_files.dart	View		3 chunks	+12 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm https://codereview.chromium.org/12918018/diff/3/pkg/intl/lib/date_format.dart File pkg/intl/lib/date_format.dart (left): https://codereview.chromium.org/12918018/diff/3/pkg/intl/lib/date_format.dart#oldcode589 pkg/intl/lib/date_format.dart:589: List _reverse(List list) { yay!

7 years, 9 months ago (2013-03-18 22:45:14 UTC) #2

Alan Knight

7 years, 9 months ago (2013-03-18 22:47:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20182 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12918018: Update Intl's json data file generation to current APIs (Closed)

Description

Patch Set 1 #

Patch Set 2 : Also remove polyfill reversing method #

Messages