Issue 1291543003: Revert "VM: Materialize stub pc-markers (smi 0) eagerly on deoptimization."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1291543003: Revert "VM: Materialize stub pc-markers (smi 0) eagerly on deoptimization." (Closed)

Created:
5 years, 4 months ago by Florian Schneider

Modified:
5 years, 4 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "VM: Materialize stub pc-markers (smi 0) eagerly on deoptimization." This reverts commit fee8daa5c58dda650df5166b6e549356d3d94161. Check if this was the reason for dart2js flaky crashes. R=floitsch@google.com TBR=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/922516fbba00a561522c333795a95e9023e70e0e

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	runtime/vm/deferred_objects.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	runtime/vm/deopt_instructions.cc	View		1 chunk	+1 line, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

Florian Schneider

5 years, 4 months ago (2015-08-17 12:48:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
922516fbba00a561522c333795a95e9023e70e0e (presubmit successful).