Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1291333002: Revert "dart2js cps: Compile some loops as 'for' loops." (Closed)

Created:
5 years, 4 months ago by asgerf
Modified:
5 years, 4 months ago
Reviewers:
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "dart2js cps: Compile some loops as 'for' loops." This reverts commit 296cb0b5b45575f9e32acd2cbad2b8969e56cb77. TBR=kmillikin@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e1f4ae5482e171b1a6cac9258e07e61d5b342826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -157 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 2 chunks +3 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/loop_rewriter.dart View 4 chunks +7 lines, -72 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/variable_merger.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_integrity.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 8 chunks +15 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
asgerf
5 years, 4 months ago (2015-08-14 12:34:09 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1f4ae5482e171b1a6cac9258e07e61d5b342826 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698