dart2js: fail gracefully with invalid package config

dart2js: fail gracefully with invalid package config

Fixes #24118
Fixes #24120
Fixes #24121
Fixes #24122

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/98e67aa065809ded6e27cb27d3a46b06b77e90c2

[Harry Terkelsen, 2015-08-19 22:21:14]

het@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-08-19 22:39:39]

lgtm

https://codereview.chromium.org/1291283006/diff/1/pkg/compiler/lib/src/apiimp...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/1291283006/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:405: } on FormatException catch (e) {
since the error messages are the same, do we actually need both this catch and
the async catchError or would catchError below be enough?

https://codereview.chromium.org/1291283006/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:406: reportError(NO_LOCATION_SPANNABLE,
MessageKind.INVALID_PACKAGE_CONFIG,
not a big priority, but it would be interesting to add span locations to the
package files. Maybe open a bug on the package-config package?

https://codereview.chromium.org/1291283006/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:412: {'uri': packageConfig, 'exception':
error});
also add `packages = Packages.noPackages`?

[Harry Terkelsen, 2015-08-19 22:56:30]

https://codereview.chromium.org/1291283006/diff/1/pkg/compiler/lib/src/apiimp...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/1291283006/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:405: } on FormatException catch (e) {
On 2015/08/19 22:39:39, Siggi Cherem (dart-lang) wrote:
> since the error messages are the same, do we actually need both this catch and
> the async catchError or would catchError below be enough?

Done.

https://codereview.chromium.org/1291283006/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:406: reportError(NO_LOCATION_SPANNABLE,
MessageKind.INVALID_PACKAGE_CONFIG,
On 2015/08/19 22:39:39, Siggi Cherem (dart-lang) wrote:
> not a big priority, but it would be interesting to add span locations to the
> package files. Maybe open a bug on the package-config package?

Filed a FR with package_config:
https://github.com/dart-lang/package_config/issues/33

https://codereview.chromium.org/1291283006/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:412: {'uri': packageConfig, 'exception':
error});
On 2015/08/19 22:39:39, Siggi Cherem (dart-lang) wrote:
> also add `packages = Packages.noPackages`?

Done.

[Harry Terkelsen, 2015-08-19 23:00:41]

Committed patchset #2 (id:20001) manually as
98e67aa065809ded6e27cb27d3a46b06b77e90c2 (presubmit successful).