Issue 1291073002: dart2js cps: Add logical rewriter rules to favor null-aware operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1291073002: dart2js cps: Add logical rewriter rules to favor null-aware operators. (Closed)

Created:
5 years, 4 months ago by asgerf

Modified:
5 years, 4 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Add logical rewriter rules to favor null-aware operators. These useful patterns arise with null-aware operators: x ? y : x ==> x && y x ? x : y ==> x || y BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/0e46c8dec97d5ab10c06900c67eeceb1f3e065ba Committed: https://github.com/dart-lang/sdk/commit/d3d7de8c125614c31506aa5898054bddb6082249

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
	M	pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart	View	1 2	3 chunks	+41 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

asgerf

Committed patchset #1 (id:1) manually as 0e46c8dec97d5ab10c06900c67eeceb1f3e065ba (presubmit successful).

5 years, 4 months ago (2015-08-14 10:07:43 UTC) #4

asgerf

5 years, 4 months ago (2015-08-18 09:09:05 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
d3d7de8c125614c31506aa5898054bddb6082249 (presubmit successful).