Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1290903002: dart2js: don't add a trailing slash when reading --packages (Closed)

Created:
5 years, 4 months ago by Harry Terkelsen
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: don't add a trailing slash when reading --packages BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/44f890b3c8a5963f348f771c1bd4ff656e7a466e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M pkg/compiler/lib/src/dart2js.dart View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Harry Terkelsen
5 years, 4 months ago (2015-08-12 23:07:36 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 4 months ago (2015-08-12 23:26:01 UTC) #3
Harry Terkelsen
5 years, 4 months ago (2015-08-12 23:28:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
44f890b3c8a5963f348f771c1bd4ff656e7a466e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698