Issue 12908005: Allow recursive inlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12908005: Allow recursive inlining. (Closed)

Created:
7 years, 9 months ago by srdjan

Modified:
7 years, 9 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

srdjan

This change gives +10% for BinaryTree and 3x for Recurse. Golem is down again, no ...

7 years, 9 months ago (2013-03-21 22:37:03 UTC) #1

Kevin Millikin (Google)

LGTM, but we should take a look at what it does to dart2js compilation times.

7 years, 9 months ago (2013-03-22 10:18:44 UTC) #2

srdjan

7 years, 9 months ago (2013-03-22 17:08:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20389 (presubmit successful).