Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290743003: reformat and 2 new tests for #23501 (Closed)

Created:
5 years, 4 months ago by danrubel
Modified:
5 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -113 lines) Patch
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 85 chunks +358 lines, -113 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
5 years, 4 months ago (2015-08-12 16:31:40 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/1290743003/diff/1/pkg/analysis_server/test/services/completion/completion_test_util.dart File pkg/analysis_server/test/services/completion/completion_test_util.dart (right): https://codereview.chromium.org/1290743003/diff/1/pkg/analysis_server/test/services/completion/completion_test_util.dart#newcode2 pkg/analysis_server/test/services/completion/completion_test_util.dart:2: Unintentional extra newline.
5 years, 4 months ago (2015-08-12 17:01:00 UTC) #3
danrubel
Committed patchset #1 (id:1) manually as 0aaa3bd0a467e176957c1e2995047781aab34ea0 (presubmit successful).
5 years, 4 months ago (2015-08-17 15:20:28 UTC) #4
danrubel
5 years, 3 months ago (2015-08-26 14:03:57 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1290743003/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/completion/completion_test_util.dart
(right):

https://codereview.chromium.org/1290743003/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/completion_test_util.dart:2: 
On 2015/08/12 17:00:59, Paul Berry wrote:
> Unintentional extra newline.

Removed

Powered by Google App Engine
This is Rietveld 408576698