KeyboardEventStream: lock it down

KeyboardEventStream: lock it down

Use superclass
remove unused _callbacks field
Make most fields final
use static, const, final where applicable

Committed: https://code.google.com/p/dart/source/detail?r=20568

[kevmoo-old, 2013-03-27 13:09:56]

PTAL

[Anton Muhin, 2013-03-27 13:49:55]

dbc

https://codereview.chromium.org/12907019/diff/1/tools/dom/src/KeyboardEventSt...
File tools/dom/src/KeyboardEventStream.dart (right):

https://codereview.chromium.org/12907019/diff/1/tools/dom/src/KeyboardEventSt...
tools/dom/src/KeyboardEventStream.dart:19: List<KeyboardEvent> _keyDownList =
[];
that's not quite safe: it should be <KeyboardEvent>[], otherwise you loose
typechecks.

https://codereview.chromium.org/12907019/diff/1/tools/dom/src/KeyboardEventSt...
tools/dom/src/KeyboardEventStream.dart:93: _type = type, _target = null,
super(_EVENT_TYPE) {
do you need explicit initliasation to null?  and why not this.type?

https://codereview.chromium.org/12907019/diff/1/tools/dom/src/KeyboardEventSt...
tools/dom/src/KeyboardEventStream.dart:102: _type = type, _target = target,
super(_EVENT_TYPE) {
ditto, this._type, this._target

[kevmoo-old, 2013-03-27 13:59:02]

this._type is goodness.
Must explicitly init all finals. Even if it's just to null.

PTAL

[Anton Muhin, 2013-03-27 14:00:38]

Thanks!

https://codereview.chromium.org/12907019/diff/3002/tools/dom/src/KeyboardEven...
File tools/dom/src/KeyboardEventStream.dart (right):

https://codereview.chromium.org/12907019/diff/3002/tools/dom/src/KeyboardEven...
tools/dom/src/KeyboardEventStream.dart:102: _target = target, super(_EVENT_TYPE)
{
this._target.

[kevmoo-old, 2013-03-27 14:02:56]

oops.

https://codereview.chromium.org/12907019/diff/3002/tools/dom/src/KeyboardEven...
File tools/dom/src/KeyboardEventStream.dart (right):

https://codereview.chromium.org/12907019/diff/3002/tools/dom/src/KeyboardEven...
tools/dom/src/KeyboardEventStream.dart:102: _target = target, super(_EVENT_TYPE)
{
On 2013/03/27 14:00:38, Anton Muhin wrote:
> this._target.

Yup!

[Emily Fortuna, 2013-03-27 17:26:40]

lovely cleanups. I'm embarrassed I missed them myself.
lgtm after you replace the tab with spaces.

https://codereview.chromium.org/12907019/diff/6002/tools/dom/src/KeyboardEven...
File tools/dom/src/KeyboardEventStream.dart (left):

https://codereview.chromium.org/12907019/diff/6002/tools/dom/src/KeyboardEven...
tools/dom/src/KeyboardEventStream.dart:22: List<Function> _callbacks;
thank you!

https://codereview.chromium.org/12907019/diff/6002/tools/dom/src/KeyboardEven...
File tools/dom/src/KeyboardEventStream.dart (right):

https://codereview.chromium.org/12907019/diff/6002/tools/dom/src/KeyboardEven...
tools/dom/src/KeyboardEventStream.dart:100:
_KeyboardEventHandler.initializeAllEventListeners(this._type, this._target) :
this._type (d'oh!)

https://codereview.chromium.org/12907019/diff/6002/tools/dom/src/KeyboardEven...
tools/dom/src/KeyboardEventStream.dart:101: super(_EVENT_TYPE) {
tab alert! convert this to spaces, please.

[kevmoo-old, 2013-03-27 17:41:24]

Committed patchset #6 manually as r20568 (presubmit successful).