Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 12907010: Fix some of teh scalarlist tests to use the TypedData VM class. (Closed)

Created:
7 years, 9 months ago by siva
Modified:
7 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix some of the scalarlist tests to use TypedData VM classes. This is in preparation for removing dart:scalarlist support from the VM. Committed: https://code.google.com/p/dart/source/detail?r=20532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -521 lines) Patch
M runtime/vm/benchmark_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/object_test.cc View 4 chunks +73 lines, -481 lines 0 comments Download
M runtime/vm/raw_object.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 2 chunks +34 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 9 months ago (2013-03-26 01:28:00 UTC) #1
hausner
lgtm
7 years, 9 months ago (2013-03-26 05:54:47 UTC) #2
siva
7 years, 9 months ago (2013-03-26 18:46:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698