dart2js: remove trailing 0 byte when reading .packages

dart2js: remove trailing 0 byte when reading .packages

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/43e6b8b8dba3138aa2dbe0eaa45bda7fd1e5927d

[Harry Terkelsen, 2015-08-13 00:12:53]

het@google.com changed reviewers:
+ sigmund@google.com, sra@google.com

[Siggi Cherem (dart-lang), 2015-08-13 00:52:20]

https://codereview.chromium.org/1290643007/diff/1/pkg/compiler/lib/src/apiimp...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/1290643007/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:395: // The input provider may put a trailing
0 byte when it reads a source
I'm surprised that we get a null terminated string - any reason why the input
provider is including that?

[Harry Terkelsen, 2015-08-13 17:02:41]

https://codereview.chromium.org/1290643007/diff/1/pkg/compiler/lib/src/apiimp...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/1290643007/diff/1/pkg/compiler/lib/src/apiimp...
pkg/compiler/lib/src/apiimpl.dart:395: // The input provider may put a trailing
0 byte when it reads a source
On 2015/08/13 00:52:19, Siggi Cherem (dart-lang) wrote:
> I'm surprised that we get a null terminated string - any reason why the input
> provider is including that?

I asked Johnni about it this morning. It apparently speeds up scanning to have
the trailing sentinel \0.

[Siggi Cherem (dart-lang), 2015-08-13 17:10:26]

lgtm

[Harry Terkelsen, 2015-08-13 17:12:02]

Committed patchset #2 (id:20001) manually as
43e6b8b8dba3138aa2dbe0eaa45bda7fd1e5927d (presubmit successful).