Issue 1290643005: Remove load graph from isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1290643005: Remove load graph from isolate (Closed)

Created:
5 years, 4 months ago by Cutch

Modified:
5 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove load graph from isolate BUG= Committed: https://github.com/dart-lang/sdk/commit/10de20f2307cfc96cba12a47343bae4ddfb61418

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -106 lines)			Patch
M	runtime/observatory/lib/src/elements/isolate_view.dart	View	1 chunk	+0 lines, -99 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/isolate_view.html	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/observatory/tests/service/debugger_location_test.dart	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

https://codereview.chromium.org/1290643005/diff/1/runtime/observatory/tests/service/debugger_location_test.dart File runtime/observatory/tests/service/debugger_location_test.dart (right): https://codereview.chromium.org/1290643005/diff/1/runtime/observatory/tests/service/debugger_location_test.dart#newcode15 runtime/observatory/tests/service/debugger_location_test.dart:15: while (i == 0) { fixes an analyzer warning

5 years, 4 months ago (2015-08-12 22:12:33 UTC) #2

Cutch

Committed patchset #1 (id:1) manually as 10de20f2307cfc96cba12a47343bae4ddfb61418 (presubmit successful).

5 years, 4 months ago (2015-08-12 22:13:16 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages