Add tests for simple packages scenarios

Add tests for simple packages scenarios

BUG=
R=iposva@google.com, pquitslund@google.com

Committed: https://github.com/dart-lang/sdk/commit/f65c675c16be47138f2933fb94dba5ee5b4b437b

[Harry Terkelsen, 2015-08-12 00:34:35]

het@google.com changed reviewers:
+ iposva@google.com, pquitslund@google.com, sethladd@google.com

[Harry Terkelsen, 2015-08-12 00:34:36]

I added tests for a few of the scenarios we discussed, let me know if you like
this organization before I write all of them this way.

dartanalyzer fails on these tests. Who should we contact to get them fixed?

[sethladd, 2015-08-12 01:13:15]

sethladd@google.com changed reviewers:
+ brianwilkerson@google.com, danrubel@google.com

[sethladd, 2015-08-12 01:13:16]

+ Brian, DanR for dartanalyzer

[Ivan Posva, 2015-08-12 05:59:55]

I really like the way how the different scenarios are isolated from each other
in a very explicit and understandable way.

Thanks,
-Ivan

[Harry Terkelsen, 2015-08-12 23:42:44]

Added a few more scenarios. This covers almost all scenarios that we have
outlined. The tests have already uncovered some bugs in the dart2js
implementation: https://codereview.chromium.org/1290903002/

[Harry Terkelsen, 2015-08-17 23:40:42]

This is ready to go if someone can lgtm

[Ivan Posva, 2015-08-17 23:48:00]

Otherwise LGTM.

-Ivan

https://codereview.chromium.org/1290623002/diff/60001/tests/standalone/packag...
File
tests/standalone/package/scenarios/both_dir_and_file/prefers_packages_file_test.dart
(right):

https://codereview.chromium.org/1290623002/diff/60001/tests/standalone/packag...
tests/standalone/package/scenarios/both_dir_and_file/prefers_packages_file_test.dart:7:
library prefers_packages_file_test;
This scenario appears to be missing the "no imports" variant of the test.

[pquitslund, 2015-08-18 00:06:08]

lgtm

[Harry Terkelsen, 2015-08-18 00:13:24]

Committed patchset #5 (id:80001) manually as
f65c675c16be47138f2933fb94dba5ee5b4b437b (presubmit successful).

[Harry Terkelsen, 2015-08-18 00:14:22]

I had to disable the 'discovery' tests for the analyzer. The analyzer passes the
test when the --packages option is provided.

https://codereview.chromium.org/1290623002/diff/60001/tests/standalone/packag...
File
tests/standalone/package/scenarios/both_dir_and_file/prefers_packages_file_test.dart
(right):

https://codereview.chromium.org/1290623002/diff/60001/tests/standalone/packag...
tests/standalone/package/scenarios/both_dir_and_file/prefers_packages_file_test.dart:7:
library prefers_packages_file_test;
On 2015/08/17 23:48:00, Ivan Posva wrote:
> This scenario appears to be missing the "no imports" variant of the test.

Done.

[pquitslund, 2015-08-18 16:12:50]

On 2015/08/18 00:14:22, Harry Terkelsen wrote:
> I had to disable the 'discovery' tests for the analyzer. The analyzer passes
the
> test when the --packages option is provided.
> 

And this is because the CWD is wrong for discovery I'm guessing?  What is the
CWD when run on the bots?

[Harry Terkelsen, 2015-08-18 17:17:41]

On 2015/08/18 16:12:50, pquitslund wrote:
> On 2015/08/18 00:14:22, Harry Terkelsen wrote:
> > I had to disable the 'discovery' tests for the analyzer. The analyzer passes
> the
> > test when the --packages option is provided.
> > 
> 
> And this is because the CWD is wrong for discovery I'm guessing?  What is the
> CWD when run on the bots?

Talking with Paul Berry last week, he said that the analyzer does not discover
the .packages file relative to the Dart source currently being analyzed, which
is the cause of the test failures. One option we were discussing was to start a
new dartanalyzer instance with CWD as the test directory when 'PackageRoot=None'
is seen in the test.
I'm not 100% sure what the CWD is when run on the bots, but I believe it is the
root of the repository.

[Ivan Posva, 2015-08-18 17:52:08]

On 2015/08/18 17:17:41, Harry Terkelsen wrote:
> On 2015/08/18 16:12:50, pquitslund wrote:
> > On 2015/08/18 00:14:22, Harry Terkelsen wrote:
> > > I had to disable the 'discovery' tests for the analyzer. The analyzer
passes
> > the
> > > test when the --packages option is provided.
> > > 
> > 
> > And this is because the CWD is wrong for discovery I'm guessing?  What is
the
> > CWD when run on the bots?
> 
> Talking with Paul Berry last week, he said that the analyzer does not discover
> the .packages file relative to the Dart source currently being analyzed, which
> is the cause of the test failures. One option we were discussing was to start
a
> new dartanalyzer instance with CWD as the test directory when
'PackageRoot=None'
> is seen in the test.
> I'm not 100% sure what the CWD is when run on the bots, but I believe it is
the
> root of the repository.

The spec says that you need to find the .packages file relative to the main
script and it is independent of the current working directory. It would actually
be wrong to go looking in the CWD for the .packages file. In short the .packages
file needs to be found the same way a package/ directory is, starting next to
the main script.

Not having the CWD be where the main script is located is actually a feature of
the bots.

-Ivan