Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1290613002: Allow simulator runs on Windows: (Closed)

Created:
5 years, 4 months ago by Ivan Posva
Modified:
5 years, 4 months ago
Reviewers:
koda, srdjan, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow simulator runs on Windows: - Fix HOST_ARCH_ vs TARGET_ARCH_ confusion. BUG= R=koda@google.com, srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/9cb6680e54cd54c7f04360276c17a4f6005ce42c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M runtime/vm/atomic_win.h View 2 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/thread_interrupter_win.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ivan Posva
5 years, 4 months ago (2015-08-11 23:57:26 UTC) #2
srdjan
lgtm
5 years, 4 months ago (2015-08-12 00:01:30 UTC) #4
koda
lgtm
5 years, 4 months ago (2015-08-12 00:59:05 UTC) #5
Ivan Posva
5 years, 4 months ago (2015-08-12 00:59:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9cb6680e54cd54c7f04360276c17a4f6005ce42c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698