Issue 1290433002: dart2js: Inline Primitives.identicalImplementation into identical patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1290433002: dart2js: Inline Primitives.identicalImplementation into identical patch. (Closed)

Created:
5 years, 4 months ago by karlklose

Modified:
5 years, 3 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js: Inline Primitives.identicalImplementation into identical patch. This gets rid of one layer of indirection that was not necessary and implements the conditional completely in JavaScript which avoids the potential for recursion when generating the intermediate representation for boolean conversion. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/9a3b5614de7105f3d486812a4d3fee783c0d9db0

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	sdk/lib/_internal/js_runtime/lib/core_patch.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	sdk/lib/_internal/js_runtime/lib/js_helper.dart	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

5 years, 3 months ago (2015-08-26 09:25:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9a3b5614de7105f3d486812a4d3fee783c0d9db0 (presubmit successful).

Expand Messages | Collapse Messages