Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1290263002: Remove dart2js-specific annotations from childNodes (Closed)

Created:
5 years, 4 months ago by Alan Knight
Modified:
5 years, 4 months ago
Reviewers:
terry, sra1
CC:
reviews_dartlang.org, ricow1, jakemac
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dart2js-specific annotations from childNodes BUG= R=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/89b99e60bfba07203aab614cd1a2e31f403cbfb7

Patch Set 1 #

Patch Set 2 : And regenerate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
Turns out it wasn't being generated, it was just copy-pasted in a template, and was ...
5 years, 4 months ago (2015-08-13 21:34:10 UTC) #2
terry
lgtm
5 years, 4 months ago (2015-08-14 13:46:02 UTC) #3
Alan Knight
5 years, 4 months ago (2015-08-14 16:32:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
89b99e60bfba07203aab614cd1a2e31f403cbfb7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698