Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1290023002: Hide empty CPU profile on class page (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -39 lines) Patch
M runtime/observatory/lib/src/elements/class_view.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.dart View 3 chunks +8 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.html View 3 chunks +43 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 4 months ago (2015-08-12 23:37:03 UTC) #2
rmacnak
lgtm
5 years, 4 months ago (2015-08-12 23:38:32 UTC) #3
Cutch
5 years, 4 months ago (2015-08-12 23:39:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cacacfa64549b4b275f3877ac12e86f98b049f3c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698