Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1289923002: Suppress stream subscription error (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suppress stream subscription error - Hides a scary exception popup in the debugger in Dartium (where stdout and stderr streams are not available). R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d0f216eb30f764470cca62413938f7cc4192c8ed

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 4 months ago (2015-08-12 18:02:56 UTC) #2
rmacnak
lgtm
5 years, 4 months ago (2015-08-12 18:05:50 UTC) #3
Cutch
5 years, 4 months ago (2015-08-12 18:11:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d0f216eb30f764470cca62413938f7cc4192c8ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698