Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1289913002: Make declaration annotations direct links; update annotations after the library's declarations are … (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make declaration annotations direct links; update annotations after the library's declarations are fully loaded. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/62dbce855558492323b8f0344ddff59f07f4ff11

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -137 lines) Patch
M runtime/observatory/lib/src/elements/library_view.html View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 15 chunks +99 lines, -132 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.html View 1 chunk +7 lines, -0 lines 2 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-12 17:50:15 UTC) #2
Cutch
LGTM with a comment https://codereview.chromium.org/1289913002/diff/1/runtime/observatory/lib/src/elements/script_inset.html File runtime/observatory/lib/src/elements/script_inset.html (right): https://codereview.chromium.org/1289913002/diff/1/runtime/observatory/lib/src/elements/script_inset.html#newcode8 runtime/observatory/lib/src/elements/script_inset.html:8: color: #0489c3; Should these be ...
5 years, 4 months ago (2015-08-12 19:25:49 UTC) #3
rmacnak
https://codereview.chromium.org/1289913002/diff/1/runtime/observatory/lib/src/elements/script_inset.html File runtime/observatory/lib/src/elements/script_inset.html (right): https://codereview.chromium.org/1289913002/diff/1/runtime/observatory/lib/src/elements/script_inset.html#newcode8 runtime/observatory/lib/src/elements/script_inset.html:8: color: #0489c3; On 2015/08/12 19:25:48, Cutch wrote: > Should ...
5 years, 4 months ago (2015-08-12 19:33:26 UTC) #4
rmacnak
5 years, 4 months ago (2015-08-12 19:37:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
62dbce855558492323b8f0344ddff59f07f4ff11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698