Issue 12899003: Attempting to stabilize node_model_test on IE9

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12899003: Attempting to stabilize node_model_test on IE9 (Closed)

Created:
7 years, 9 months ago by blois

Modified:
7 years, 9 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Attempting to stabilize node_model_test on IE9 Basically the test is passing fine on my IE9 VMs and the individual tests are passing on the bots, but it appears that when everything is run together on the bots, that the tests fail. What I believe is happening is that we're delaying the MutationEvents using window.setImmediate which is being polyfilled on IE9 to window.setTimeout(0) and running into a timing issue on slow machines with the test. We should have a much better resolution once we get a proper setImmediate from dart2js. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20119

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	M	tests/html/node_model_test.dart	View		5 chunks	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 9 months ago (2013-03-15 22:52:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20119 (presubmit successful).

Expand Messages | Collapse Messages