Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1289883004: Fix simulators. (Closed)

Created:
5 years, 4 months ago by koda
Modified:
5 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M runtime/vm/assembler_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/longjump.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 4 months ago (2015-08-17 20:42:54 UTC) #2
srdjan
lgtm
5 years, 4 months ago (2015-08-17 20:44:04 UTC) #3
koda
5 years, 4 months ago (2015-08-17 20:46:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0fe9feefa2b1b6eec609a7cbbdbab18a53c9df3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698