Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1289713002: Enable analyzer tests after fixing them for analysis (Closed)

Created:
5 years, 4 months ago by srdjan
Modified:
5 years, 4 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable analyzer tests after fixing them for analysis BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/30d68644a1dab863de0719e1211a8f4f2a50a764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/string_interpolation_and_buffer_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/language/string_split_test.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 4 months ago (2015-08-12 00:22:30 UTC) #2
Paul Berry
lgtm, thanks!
5 years, 4 months ago (2015-08-12 00:34:19 UTC) #3
srdjan
5 years, 4 months ago (2015-08-12 00:43:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
30d68644a1dab863de0719e1211a8f4f2a50a764 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698