Issue 128933003: Add ClassMirror.isAbstract to the API and VM implementation.

Issue 128933003: Add ClassMirror.isAbstract to the API and VM implementation. (Closed)

Created:
6 years, 11 months ago by rmacnak

Modified:
6 years, 11 months ago

Reviewers:
gbracha, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add ClassMirror.isAbstract to the API and VM implementation. BUG=http://dartbug.com/12826 R=asiva@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=31630

Patch Set 3 : also test function types #

Total comments: 2

Patch Set 4 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -5 lines)			Patch
M	runtime/lib/mirrors.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/lib/mirrors/abstract_class_test.dart	View	1 2 3	1 chunk	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

gbracha

tests lgtm with nagging comments. https://codereview.chromium.org/128933003/diff/160001/tests/lib/mirrors/abstract_class_test.dart File tests/lib/mirrors/abstract_class_test.dart (right): https://codereview.chromium.org/128933003/diff/160001/tests/lib/mirrors/abstract_class_test.dart#newcode44 tests/lib/mirrors/abstract_class_test.dart:44: Expect.isFalse(reflect(new FunctionBar()).type.isAbstract); Why is ...

6 years, 11 months ago (2014-01-08 21:33:23 UTC) #2

rmacnak

https://codereview.chromium.org/128933003/diff/160001/tests/lib/mirrors/abstract_class_test.dart File tests/lib/mirrors/abstract_class_test.dart (right): https://codereview.chromium.org/128933003/diff/160001/tests/lib/mirrors/abstract_class_test.dart#newcode44 tests/lib/mirrors/abstract_class_test.dart:44: Expect.isFalse(reflect(new FunctionBar()).type.isAbstract); On 2014/01/08 21:33:24, gbracha wrote: > Why ...

6 years, 11 months ago (2014-01-08 21:53:55 UTC) #3

rmacnak

6 years, 11 months ago (2014-01-08 22:21:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r31630 (presubmit successful).

Expand Messages | Collapse Messages