Issue 1289303002: Update dartium DEPS to use co19 from github.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1289303002: Update dartium DEPS to use co19 from github. (Closed)

Created:
5 years, 4 months ago by Bill Hesse

Modified:
5 years, 4 months ago

Reviewers:
terry

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update dartium DEPS to use co19 from github. BUG= R=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/4bc7c0e8f3882725a5fc41f378808d661f8cd601

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/deps/dartium.deps/DEPS	View		2 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

We don't have a github mirror variable in the dartium DEPS file.

5 years, 4 months ago (2015-08-14 15:53:22 UTC) #2

terry

lgtm https://codereview.chromium.org/1289303002/diff/1/tools/deps/dartium.deps/DEPS File tools/deps/dartium.deps/DEPS (right): https://codereview.chromium.org/1289303002/diff/1/tools/deps/dartium.deps/DEPS#newcode56 tools/deps/dartium.deps/DEPS:56: "co19_rev": "@f95f109fea67127a220958794ef5200a63cb454c", The SHA1 should be 34010003cd3e74085084c92816247b53cc8be491 however, ...

5 years, 4 months ago (2015-08-14 16:07:48 UTC) #3

Bill Hesse

5 years, 4 months ago (2015-08-14 16:22:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4bc7c0e8f3882725a5fc41f378808d661f8cd601 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages