Issue 12893011: Update idl files in third_party/WebCore

Issue 12893011: Update idl files in third_party/WebCore (Closed)

Created:
7 years, 9 months ago by Mads Ager (google)

Modified:
7 years, 9 months ago

Reviewers:
Anton Muhin, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/third_party/WebCore

Visibility:
Public.

More Reviews

Description

Update idl files in third_party/WebCore R=antonm@google.com,blois@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=20375

Patch Set 1 #

Total comments: 8

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+233 lines, -226 lines)			Patch
M	Modules/indexeddb/IDBCursor.idl	View	1 chunk	+1 line, -2 lines	2 comments	Download
M	Modules/indexeddb/IDBFactory.idl	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Modules/indexeddb/IDBRequest.idl	View	1 chunk	+1 line, -1 line	2 comments	Download
M	Modules/mediastream/RTCPeerConnection.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	Modules/mediastream/RTCStatsElement.idl	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	Modules/mediastream/RTCStatsReport.idl	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	Modules/mediastream/RTCStatsResponse.idl	View	1 chunk	+3 lines, -1 line	2 comments	Download
M	Modules/quota/DOMWindowQuota.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	Modules/quota/NavigatorStorageQuota.idl	View	2 chunks	+5 lines, -5 lines	0 comments	Download
A +	Modules/quota/StorageErrorCallback.idl	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Modules/quota/StorageInfo.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	Modules/quota/StorageInfoErrorCallback.idl	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	Modules/quota/StorageInfoQuotaCallback.idl	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	Modules/quota/StorageInfoUsageCallback.idl	View	1 chunk	+0 lines, -36 lines	0 comments	Download
A +	Modules/quota/StorageQuota.idl	View	2 chunks	+4 lines, -7 lines	0 comments	Download
A +	Modules/quota/StorageQuotaCallback.idl	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	Modules/quota/StorageUsageCallback.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Modules/speech/SpeechSynthesisUtterance.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Modules/webaudio/AudioContext.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Modules/webaudio/AudioDestinationNode.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Modules/webaudio/ScriptProcessorNode.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	README	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bindings/dart/gyp/scripts/massage_factories.py	View	2 chunks	+11 lines, -3 lines	0 comments	Download
M	bindings/scripts/test/TestObj.idl	View	2 chunks	+24 lines, -0 lines	0 comments	Download
A +	css/CSSFontFaceLoadEvent.idl	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	css/CSSFontFaceRule.idl	View	1 chunk	+4 lines, -1 line	0 comments	Download
A +	css/FontLoader.idl	View	3 chunks	+15 lines, -7 lines	2 comments	Download
M	dom/Document.idl	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	html/HTMLAudioElement.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	html/HTMLDocument.idl	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	html/HTMLMediaElement.idl	View	1 chunk	+2 lines, -1 line	0 comments	Download
A +	html/canvas/WebGLCompressedTextureATC.idl	View	2 chunks	+5 lines, -6 lines	0 comments	Download
A +	html/track/TextTrackRegion.idl	View	2 chunks	+22 lines, -8 lines	0 comments	Download
M	inspector/Inspector.json	View	6 chunks	+74 lines, -8 lines	0 comments	Download
M	inspector/InspectorFrontendHost.idl	View	4 chunks	+6 lines, -4 lines	0 comments	Download
M	page/DOMWindow.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	testing/InternalSettings.idl	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	testing/Internals.idl	View	5 chunks	+10 lines, -3 lines	0 comments	Download
M	testing/TypeConversions.idl	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

Committed patchset #1 manually as r20375 (presubmit successful).

7 years, 9 months ago (2013-03-22 11:53:42 UTC) #2

Anton Muhin

lgtm https://codereview.chromium.org/12893011/diff/1/Modules/indexeddb/IDBCursor.idl File Modules/indexeddb/IDBCursor.idl (right): https://codereview.chromium.org/12893011/diff/1/Modules/indexeddb/IDBCursor.idl#newcode38 Modules/indexeddb/IDBCursor.idl:38: void advance(in [EnforceRange] unsigned long count) do we ...

7 years, 9 months ago (2013-03-22 12:04:27 UTC) #3

Mads Ager (google)

7 years, 9 months ago (2013-03-22 13:21:08 UTC) #4

Message was sent while issue was closed.

Thanks Anton!

https://codereview.chromium.org/12893011/diff/1/Modules/indexeddb/IDBCursor.idl
File Modules/indexeddb/IDBCursor.idl (right):

https://codereview.chromium.org/12893011/diff/1/Modules/indexeddb/IDBCursor.i...
Modules/indexeddb/IDBCursor.idl:38: void advance(in [EnforceRange] unsigned long
count)
On 2013/03/22 12:04:27, Anton Muhin wrote:
> do we need support for this in C++ bindings?

Most likely. I'm on my way out on vacation and will be out for a week. Let me
file a bug report to look into this.

https://codereview.chromium.org/12893011/diff/1/Modules/indexeddb/IDBRequest.idl
File Modules/indexeddb/IDBRequest.idl (right):

https://codereview.chromium.org/12893011/diff/1/Modules/indexeddb/IDBRequest....
Modules/indexeddb/IDBRequest.idl:36: readonly attribute IDBAny result
On 2013/03/22 12:04:27, Anton Muhin wrote:
> anything we can remove?

I'll double check! Thanks.

https://codereview.chromium.org/12893011/diff/1/Modules/mediastream/RTCStatsR...
File Modules/mediastream/RTCStatsResponse.idl (right):

https://codereview.chromium.org/12893011/diff/1/Modules/mediastream/RTCStatsR...
Modules/mediastream/RTCStatsResponse.idl:28: ] interface RTCStatsResponse {
On 2013/03/22 12:04:27, Anton Muhin wrote:
> we probably need some custom magic here: get(propertyName) or alike.

I'll file a bug report for this on as well.

https://codereview.chromium.org/12893011/diff/1/css/FontLoader.idl
File css/FontLoader.idl (right):

https://codereview.chromium.org/12893011/diff/1/css/FontLoader.idl#newcode39
css/FontLoader.idl:39: attribute EventListener onloading;
On 2013/03/22 12:04:27, Anton Muhin wrote:
> do we have proper bindings for those automatically?
> 
> Mads, just FYI, we usually do not support attribute listeners.

I havn't seen anything break because of this and I assumed so, but we should
double check.

Expand Messages | Collapse Messages