Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1289283004: Initial steps toward adding strong mode to the new task model (Closed)

Created:
5 years, 4 months ago by Brian Wilkerson
Modified:
5 years, 4 months ago
Reviewers:
Leaf, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1229 lines, -406 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 9 chunks +54 lines, -8 lines 2 comments Download
M pkg/analyzer/lib/src/generated/element_handle.dart View 3 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 13 chunks +38 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 33 chunks +596 lines, -320 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 33 chunks +143 lines, -61 lines 2 comments Download
A pkg/analyzer/lib/src/task/strong_mode.dart View 1 chunk +82 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 59 chunks +232 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +74 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Brian Wilkerson
I apologize for the formatting noise. The only change in ast_factory.dart is on line 374. ...
5 years, 4 months ago (2015-08-17 19:49:29 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1289283004/diff/1/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/1289283004/diff/1/pkg/analyzer/lib/src/generated/element.dart#newcode3527 pkg/analyzer/lib/src/generated/element.dart:3527: * type specified for it. I cannot understand ...
5 years, 4 months ago (2015-08-17 20:08:50 UTC) #3
Leaf
lgtm also, thanks!
5 years, 4 months ago (2015-08-17 21:28:43 UTC) #4
Brian Wilkerson
https://codereview.chromium.org/1289283004/diff/1/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/1289283004/diff/1/pkg/analyzer/lib/src/generated/element.dart#newcode3527 pkg/analyzer/lib/src/generated/element.dart:3527: * type specified for it. Done https://codereview.chromium.org/1289283004/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart ...
5 years, 4 months ago (2015-08-18 00:07:04 UTC) #5
Brian Wilkerson
5 years, 4 months ago (2015-08-18 00:07:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
81fbf6af7c5a1e6ca7db8bfde345bb3f62640648 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698