Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1289243002: VM: Materialize stub pc-markers (smi 0) eagerly on deoptimization. (Closed)

Created:
5 years, 4 months ago by Florian Schneider
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Materialize stub pc-markers (smi 0) eagerly on deoptimization. Deferred objects are malloced, and there is no need to allocate one for the stub pc-marker (smi zero). This is also part of preparing for running precompiled stub code: when changing the pc-marker to hold the stub's code object, we want to materialize it eagerly, so that the stack frame is valid after DeoptimizeFillFrame. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/fee8daa5c58dda650df5166b6e549356d3d94161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M runtime/vm/deferred_objects.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 4 months ago (2015-08-14 11:15:03 UTC) #2
rmacnak
lgtm
5 years, 4 months ago (2015-08-14 20:22:45 UTC) #3
Florian Schneider
5 years, 4 months ago (2015-08-17 07:57:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fee8daa5c58dda650df5166b6e549356d3d94161 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698