Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1289113003: Add TimelinePauses analysis and tests (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -7 lines) Patch
M runtime/vm/timeline.h View 1 4 chunks +38 lines, -0 lines 0 comments Download
M runtime/vm/timeline.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/vm/timeline_analysis.h View 1 chunk +67 lines, -1 line 0 comments Download
M runtime/vm/timeline_analysis.cc View 5 chunks +201 lines, -6 lines 0 comments Download
M runtime/vm/timeline_test.cc View 2 chunks +172 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 4 months ago (2015-08-14 02:06:56 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1289113003/diff/1/runtime/vm/timeline.h File runtime/vm/timeline.h (right): https://codereview.chromium.org/1289113003/diff/1/runtime/vm/timeline.h#newcode111 runtime/vm/timeline.h:111: // Does this duration contain |other| ? ^fully ...
5 years, 4 months ago (2015-08-14 18:09:34 UTC) #3
Cutch
https://codereview.chromium.org/1289113003/diff/1/runtime/vm/timeline.h File runtime/vm/timeline.h (right): https://codereview.chromium.org/1289113003/diff/1/runtime/vm/timeline.h#newcode111 runtime/vm/timeline.h:111: // Does this duration contain |other| ? On 2015/08/14 ...
5 years, 4 months ago (2015-08-14 18:11:55 UTC) #4
Cutch
5 years, 4 months ago (2015-08-14 18:12:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
08cc68cc556aec9fb04219a9062f078aeadd0409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698