Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 12890002: Tweaking html_config to stabilize location test. (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
Reviewers:
gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Tweaking html_config to stabilize location test. I believe that changes I made recently to html_config may have destabilized the html/location_test. Basically the location_test does a hash change and when this test is run after other tests, it may be causing a browser reload. I'd actually like to refactor the printing of the results completely to build them programmatically (and clean them up?), but this is a larger change. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20092

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/unittest/lib/html_config.dart View 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 9 months ago (2013-03-15 16:49:14 UTC) #1
gram
lgtm https://codereview.chromium.org/12890002/diff/1/pkg/unittest/lib/html_config.dart File pkg/unittest/lib/html_config.dart (right): https://codereview.chromium.org/12890002/diff/1/pkg/unittest/lib/html_config.dart#newcode57 pkg/unittest/lib/html_config.dart:57: window.location.hash.contains('testFilter')) { Again, please add a comment.
7 years, 9 months ago (2013-03-15 16:51:41 UTC) #2
blois
7 years, 9 months ago (2013-03-15 16:53:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20092 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698