Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288953003: Port "Add mapping from address to id for runtime functions." (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Port "Add mapping from address to id for runtime functions." Delete some out-of-sync DECLAREs. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/d47827b88eeb8b6fad7f77a400fe4e789df5ef1f

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -137 lines) Patch
M runtime/vm/code_generator.h View 1 chunk +0 lines, -37 lines 0 comments Download
M runtime/vm/compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/runtime_entry.h View 1 4 chunks +110 lines, -3 lines 1 comment Download
M runtime/vm/stub_code_arm.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M runtime/vm/stub_code_arm64_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_arm_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M runtime/vm/stub_code_ia32_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M runtime/vm/stub_code_mips_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M runtime/vm/stub_code_x64_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-13 20:07:02 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1288953003/diff/1/runtime/vm/runtime_entry.h File runtime/vm/runtime_entry.h (right): https://codereview.chromium.org/1288953003/diff/1/runtime/vm/runtime_entry.h#newcode190 runtime/vm/runtime_entry.h:190: #define DEFINE_RUNTIME_CASE(name) \ formatting: move backslash to 80 ...
5 years, 4 months ago (2015-08-13 20:23:02 UTC) #3
rmacnak
https://codereview.chromium.org/1288953003/diff/1/runtime/vm/runtime_entry.h File runtime/vm/runtime_entry.h (right): https://codereview.chromium.org/1288953003/diff/1/runtime/vm/runtime_entry.h#newcode190 runtime/vm/runtime_entry.h:190: #define DEFINE_RUNTIME_CASE(name) \ On 2015/08/13 20:23:02, srdjan wrote: > ...
5 years, 4 months ago (2015-08-13 21:34:53 UTC) #4
rmacnak
Committed patchset #2 (id:20001) manually as d47827b88eeb8b6fad7f77a400fe4e789df5ef1f (presubmit successful).
5 years, 4 months ago (2015-08-13 21:42:35 UTC) #5
Florian Schneider
https://codereview.chromium.org/1288953003/diff/20001/runtime/vm/runtime_entry.h File runtime/vm/runtime_entry.h (right): https://codereview.chromium.org/1288953003/diff/20001/runtime/vm/runtime_entry.h#newcode66 runtime/vm/runtime_entry.h:66: V(RawObject*, TestLeafSmiAdd, RawObject*, RawObject*) \ Please move declaration of ...
5 years, 4 months ago (2015-08-14 07:25:52 UTC) #6
Florian Schneider
5 years, 4 months ago (2015-08-14 07:26:06 UTC) #7
Message was sent while issue was closed. 
On 2015/08/14 07:25:52, Florian Schneider wrote:
>
https://codereview.chromium.org/1288953003/diff/20001/runtime/vm/runtime_entry.h
> File runtime/vm/runtime_entry.h (right):
> 
>
https://codereview.chromium.org/1288953003/diff/20001/runtime/vm/runtime_entr...
> runtime/vm/runtime_entry.h:66: V(RawObject*, TestLeafSmiAdd, RawObject*,
> RawObject*)                        \
> Please move declaration of test routines to runtime_entry_test.cc.

Otherwise lgtm.

Powered by Google App Engine
This is Rietveld 408576698