Issue 1288853002: Fix cpu profile table

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1288853002: Fix cpu profile table (Closed)

Created:
5 years, 4 months ago by Cutch

Modified:
5 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix cpu profile table - Add back deleted call to buildFunctionCallerAndCallees - Pass in caller count and not callee count (copy and paste bug) - Add to isolate drop down R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/3dd39ef37cb8529af55201f8bc72e613ba6acaf2

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -4 lines)			Patch
M	runtime/observatory/lib/src/cpu_profile/cpu_profile.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/cpu_profile.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/nav_bar.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Cutch

5 years, 4 months ago (2015-08-13 00:38:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3dd39ef37cb8529af55201f8bc72e613ba6acaf2 (presubmit successful).