Support asynchronuous spawnDomFunction.

Support asynchronuous spawnDomFunction.

R=vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=20554

[Anton Muhin, 2013-03-26 18:53:59]

friendly ping

[vsm, 2013-03-26 19:13:36]

LGTM

https://codereview.chromium.org/12887009/diff/4001/samples/isolate_html/isola...
File samples/isolate_html/isolate_sample.dart (right):

https://codereview.chromium.org/12887009/diff/4001/samples/isolate_html/isola...
samples/isolate_html/isolate_sample.dart:31: return
spawnDomFunction(isolateMain).transform((sendPort) {
transform -> then?

https://codereview.chromium.org/12887009/diff/4001/tools/dom/src/native_DOMPu...
File tools/dom/src/native_DOMPublic.dart (right):

https://codereview.chromium.org/12887009/diff/4001/tools/dom/src/native_DOMPu...
tools/dom/src/native_DOMPublic.dart:16:
_Utils.spawnDomFunction(topLevelFunction, port.toSendPort().hashCode);
Yuck...  Is a Handle -> Port API coming in the VM?  It'd be great to get rid of
this.

I also worry about security / calling _Utils.spawnDomFunction with an arbitrary
int.  Other libs *shouldn't* see it, but with mirrors etc., it seems like a
potential hole.

[Anton Muhin, 2013-03-26 19:15:37]

https://codereview.chromium.org/12887009/diff/4001/samples/isolate_html/isola...
File samples/isolate_html/isolate_sample.dart (right):

https://codereview.chromium.org/12887009/diff/4001/samples/isolate_html/isola...
samples/isolate_html/isolate_sample.dart:31: return
spawnDomFunction(isolateMain).transform((sendPort) {
On 2013/03/26 19:13:37, vsm wrote:
> transform -> then? 

I have to return a future as well, hence I used transform.  Is there a way to
use .then here?

https://codereview.chromium.org/12887009/diff/4001/tools/dom/src/native_DOMPu...
File tools/dom/src/native_DOMPublic.dart (right):

https://codereview.chromium.org/12887009/diff/4001/tools/dom/src/native_DOMPu...
tools/dom/src/native_DOMPublic.dart:16:
_Utils.spawnDomFunction(topLevelFunction, port.toSendPort().hashCode);
Absolutely w/ you here, I've already asked Siva to give a more direct access to
this stuff---it's only an ugly temporary measure.

On 2013/03/26 19:13:37, vsm wrote:
> Yuck...  Is a Handle -> Port API coming in the VM?  It'd be great to get rid
of
> this.
> 
> I also worry about security / calling _Utils.spawnDomFunction with an
arbitrary
> int.  Other libs *shouldn't* see it, but with mirrors etc., it seems like a
> potential hole.

[vsm, 2013-03-26 19:21:39]

https://codereview.chromium.org/12887009/diff/4001/samples/isolate_html/isola...
File samples/isolate_html/isolate_sample.dart (right):

https://codereview.chromium.org/12887009/diff/4001/samples/isolate_html/isola...
samples/isolate_html/isolate_sample.dart:31: return
spawnDomFunction(isolateMain).transform((sendPort) {
Future.then returns a Future.  I don't see transform defined on Future.

On 2013/03/26 19:15:37, Anton Muhin wrote:
> On 2013/03/26 19:13:37, vsm wrote:
> > transform -> then? 
> 
> I have to return a future as well, hence I used transform.  Is there a way to
> use .then here?

[Anton Muhin, 2013-03-27 08:41:46]

https://codereview.chromium.org/12887009/diff/4001/samples/isolate_html/isola...
File samples/isolate_html/isolate_sample.dart (right):

https://codereview.chromium.org/12887009/diff/4001/samples/isolate_html/isola...
samples/isolate_html/isolate_sample.dart:31: return
spawnDomFunction(isolateMain).transform((sendPort) {
You're absolutely right, sorry, got confused.

On 2013/03/26 19:21:39, vsm wrote:
> Future.then returns a Future.  I don't see transform defined on Future.
> 
> On 2013/03/26 19:15:37, Anton Muhin wrote:
> > On 2013/03/26 19:13:37, vsm wrote:
> > > transform -> then? 
> > 
> > I have to return a future as well, hence I used transform.  Is there a way
to
> > use .then here?
>

[Anton Muhin, 2013-03-27 08:51:01]

Committed patchset #2 manually as r20554 (presubmit successful).