Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 12886043: Optimizing createElement_html (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 8 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Optimizing createElement_html BUG=8518 Committed: https://code.google.com/p/dart/source/detail?r=20732

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
This is to address a number of the issues raised in bug #8518 Further comments ...
7 years, 9 months ago (2013-03-21 22:38:43 UTC) #1
blois
7 years, 9 months ago (2013-03-21 22:38:53 UTC) #2
sra1
lgtm
7 years, 9 months ago (2013-03-22 07:25:09 UTC) #3
blois
7 years, 8 months ago (2013-04-01 16:54:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20732 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698