Issue 12886011: Add unhandledExceptionCallback to streamSpawnFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12886011: Add unhandledExceptionCallback to streamSpawnFunction. (Closed)

Created:
7 years, 9 months ago by floitsch

Modified:
7 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add unhandledExceptionCallback to streamSpawnFunction. Also throw error in dart2js version. BUG= http://dartbug.com/9208 Committed: https://code.google.com/p/dart/source/detail?r=20172

Patch Set 2 : Address comment. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -8 lines)			Patch
M	runtime/lib/isolate_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	sdk/lib/isolate/base.dart	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download
M	sdk/lib/isolate/isolate_stream.dart	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/12886011/diff/1/sdk/lib/isolate/base.dart File sdk/lib/isolate/base.dart (right): https://codereview.chromium.org/12886011/diff/1/sdk/lib/isolate/base.dart#newcode34 sdk/lib/isolate/base.dart:34: * See comments at the top of this ...

7 years, 9 months ago (2013-03-18 14:35:03 UTC) #2

floitsch

https://codereview.chromium.org/12886011/diff/1/sdk/lib/isolate/base.dart File sdk/lib/isolate/base.dart (right): https://codereview.chromium.org/12886011/diff/1/sdk/lib/isolate/base.dart#newcode34 sdk/lib/isolate/base.dart:34: * See comments at the top of this library ...

7 years, 9 months ago (2013-03-18 19:07:10 UTC) #3

floitsch

7 years, 9 months ago (2013-03-18 19:09:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20172 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12886011: Add unhandledExceptionCallback to streamSpawnFunction. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages