Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1288573002: Properly parse native-code V8 frames. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stack_trace@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Properly parse native-code V8 frames. Fixes dart-lang/test#316. R=rnystrom@google.com Committed: https://github.com/dart-lang/stack_trace/commit/99854763f7074bd367f5bf6a75be7cf025563155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/frame.dart View 3 chunks +6 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/frame_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-11 23:42:44 UTC) #1
Bob Nystrom
lgtm
5 years, 4 months ago (2015-08-11 23:45:27 UTC) #2
nweiz
5 years, 4 months ago (2015-08-12 00:31:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
99854763f7074bd367f5bf6a75be7cf025563155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698