Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 12881006: Add the native intrinsic TypedData_setRange to optimize the setRange call when the destination and … (Closed)

Created:
7 years, 9 months ago by siva
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add the native intrinsic TypedData_setRange to optimize the setRange call when the destination and source of setRange are of the same typeddata type. Committed: https://code.google.com/p/dart/source/detail?r=20078

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -6 lines) Patch
M runtime/lib/typeddata.cc View 1 2 chunks +71 lines, -5 lines 0 comments Download
M runtime/lib/typeddata.dart View 2 chunks +12 lines, -1 line 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +12 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 9 months ago (2013-03-15 07:41:47 UTC) #1
siva
7 years, 9 months ago (2013-03-15 08:57:10 UTC) #2
Mads Ager (google)
LGTM!
7 years, 9 months ago (2013-03-15 10:40:53 UTC) #3
siva
7 years, 9 months ago (2013-03-15 13:33:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20078 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698