Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 128803003: Fix issue 14366: in case of a type check error and conflicting type names being the same, prefix ty… (Closed)

Created:
6 years, 11 months ago by srdjan
Modified:
6 years, 11 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix issue 14366: in case of a type check error and conflicting type names being the same, prefix type names with their library names. Example: type 'myLib.My' is not a subtype of type 'My' of 'm'. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=31621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M runtime/vm/code_generator.cc View 1 chunk +20 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
6 years, 11 months ago (2014-01-08 18:47:03 UTC) #1
regis
LGTM
6 years, 11 months ago (2014-01-08 19:03:41 UTC) #2
srdjan
6 years, 11 months ago (2014-01-08 19:10:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31621 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698