dart2js cps: Handle native functions, getters, and setters.

dart2js cps: Handle native functions, getters, and setters.

R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/999ec11985146f26e6aaa7f3785ecab5c3aa1972

[asgerf, 2015-08-12 13:15:03]

LGTM if moved to the builder_task

https://codereview.chromium.org/1288013002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/1288013002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:2039: new
RegExp(r'^[a-zA-Z][a-zA-Z_$0-9]*$');
Make this static?

https://codereview.chromium.org/1288013002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:2056: if (nativeBody != null) {
I think it would make more sense to have this split in the builder_task file,
since that's where all other AST inspection takes place. The two cases could
then have separate methods on the builder.

Currently this is the only method taking an AST node as input. The import of ast
only exists so we can create DartStrings for use in constants.

[karlklose, 2015-08-24 09:01:43]

Comments addressed.

[karlklose, 2015-08-24 09:01:58]

Committed patchset #2 (id:20001) manually as
999ec11985146f26e6aaa7f3785ecab5c3aa1972 (presubmit successful).