Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1287973002: Check for one-to-many source mappings. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -29 lines) Patch
M pkg/compiler/lib/src/io/position_information.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/js_ast/test/printer_callback_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/source_mapping_test_viewer.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/source_mapping_tester.dart View 4 chunks +85 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-12 09:59:26 UTC) #2
herhut
lgtm
5 years, 4 months ago (2015-08-12 11:27:26 UTC) #3
Johnni Winther
5 years, 4 months ago (2015-08-17 07:58:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
720e72428c042a38f28aa01fb37064781f93a6f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698