Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1287673002: Don't delay values and errors from async/await functions. (Closed)

Created:
5 years, 4 months ago by floitsch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, sigurdm
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't delay values and errors from async/await functions. Fixes issue 23497. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/f2d08149fdeb5e67db1b3b4e4284cbac5a83169c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Forgot test. #

Patch Set 3 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -7 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -1 line 0 comments Download
A tests/lib/async/async_await_sync_completer_test.dart View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
We are allowed to use a sync-completer, since we only call the complete functions in ...
5 years, 4 months ago (2015-08-11 18:17:59 UTC) #2
hausner
lgtm https://codereview.chromium.org/1287673002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/1287673002/diff/1/runtime/vm/parser.cc#newcode7031 runtime/vm/parser.cc:7031: // :async_completer = new Completer(); This comment should ...
5 years, 4 months ago (2015-08-12 00:01:03 UTC) #3
floitsch
Forgot to add the test. Will commit already, but if you have comments on the ...
5 years, 4 months ago (2015-08-12 14:19:47 UTC) #4
floitsch
5 years, 4 months ago (2015-08-13 11:00:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f2d08149fdeb5e67db1b3b4e4284cbac5a83169c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698