Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 12876003: Fix escaping in YAML RegExp. (Closed)

Created:
7 years, 9 months ago by Bob Nystrom
Modified:
7 years, 9 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix escaping in YAML RegExp. This was causing it to try to parse "m4" as a number, which fails. Fixes #9128. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20107

Patch Set 1 #

Patch Set 2 : Use raw strings for regexes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M pkg/yaml/lib/composer.dart View 1 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Bob Nystrom
7 years, 9 months ago (2013-03-15 17:42:47 UTC) #1
nweiz
We should probably just use r""-style strings for all of these. I don't think those ...
7 years, 9 months ago (2013-03-15 18:14:21 UTC) #2
Bob Nystrom
On 2013/03/15 18:14:21, nweiz wrote: > We should probably just use r""-style strings for all ...
7 years, 9 months ago (2013-03-15 18:19:22 UTC) #3
nweiz
On 2013/03/15 18:19:22, Bob Nystrom wrote: > On 2013/03/15 18:14:21, nweiz wrote: > > We ...
7 years, 9 months ago (2013-03-15 18:22:25 UTC) #4
Bob Nystrom
Okey dokey. Updated everything to raw strings. PTAL!
7 years, 9 months ago (2013-03-15 20:11:18 UTC) #5
nweiz
lgtm
7 years, 9 months ago (2013-03-15 20:26:43 UTC) #6
Bob Nystrom
7 years, 9 months ago (2013-03-15 20:48:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r20107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698