Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1287543002: dart2js: add an example script that shows the distribution of code among (Closed)

Created:
5 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: add an example script that shows the distribution of code among libraries. For example, running this on the dump-info of angular2 'hello world' would produce: path 8807 1.21% stack_trace 11501 1.59% intl 14135 1.95% Loose files 142311 19.62% angular2 224171 30.90% Core libs 225120 31.03% All packages 258614 35.65% TOTAL 626045 86.30% Note that the grouping of libraries, say by package, and summary information is configurable. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/571c1d5b6e8990d07c0f93aad924454ef8e4bd4b

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -0 lines) Patch
M pkg/compiler/pubspec.yaml View 2 chunks +6 lines, -0 lines 0 comments Download
A pkg/compiler/tool/library_size_split.dart View 1 1 chunk +132 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-08-11 01:11:19 UTC) #3
Harry Terkelsen
lgtm https://codereview.chromium.org/1287543002/diff/20001/pkg/compiler/tool/library_size_split.dart File pkg/compiler/tool/library_size_split.dart (right): https://codereview.chromium.org/1287543002/diff/20001/pkg/compiler/tool/library_size_split.dart#newcode33 pkg/compiler/tool/library_size_split.dart:33: var name = group['name']; so you can only ...
5 years, 4 months ago (2015-08-11 01:43:40 UTC) #4
Siggi Cherem (dart-lang)
thanks! https://codereview.chromium.org/1287543002/diff/20001/pkg/compiler/tool/library_size_split.dart File pkg/compiler/tool/library_size_split.dart (right): https://codereview.chromium.org/1287543002/diff/20001/pkg/compiler/tool/library_size_split.dart#newcode33 pkg/compiler/tool/library_size_split.dart:33: var name = group['name']; On 2015/08/11 01:43:39, Harry ...
5 years, 4 months ago (2015-08-11 21:08:00 UTC) #6
Siggi Cherem (dart-lang)
PTAL - I forgot to say that since I added a bit of code, you ...
5 years, 4 months ago (2015-08-11 21:41:13 UTC) #7
Harry Terkelsen
lgtm
5 years, 4 months ago (2015-08-11 21:54:20 UTC) #9
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-08-11 22:00:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:80001) manually as
571c1d5b6e8990d07c0f93aad924454ef8e4bd4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698