Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1287533002: dart2js: add parent references to some info objects (Closed)

Created:
5 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M pkg/compiler/lib/src/dump_info.dart View 1 3 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/info/info.dart View 1 8 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-08-11 00:44:07 UTC) #2
Siggi Cherem (dart-lang)
(fyi this is a follow up cl that builds on top of the parser support ...
5 years, 4 months ago (2015-08-11 00:44:40 UTC) #3
Harry Terkelsen
lgtm https://codereview.chromium.org/1287533002/diff/1/pkg/compiler/lib/src/info/info.dart File pkg/compiler/lib/src/info/info.dart (right): https://codereview.chromium.org/1287533002/diff/1/pkg/compiler/lib/src/info/info.dart#newcode245 pkg/compiler/lib/src/info/info.dart:245: ..parent = parseId(json['parent']) can libraries have parents?
5 years, 4 months ago (2015-08-11 01:23:14 UTC) #4
Johnni Winther
lgtm
5 years, 4 months ago (2015-08-11 14:06:19 UTC) #5
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1287533002/diff/1/pkg/compiler/lib/src/info/info.dart File pkg/compiler/lib/src/info/info.dart (right): https://codereview.chromium.org/1287533002/diff/1/pkg/compiler/lib/src/info/info.dart#newcode245 pkg/compiler/lib/src/info/info.dart:245: ..parent = parseId(json['parent']) On 2015/08/11 01:23:14, Harry Terkelsen wrote: ...
5 years, 4 months ago (2015-08-11 16:44:27 UTC) #6
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-08-11 16:54:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ca4fbfad5a0d7d7f094c6ed0505ddc4d259e500d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698